Make SearchOrder validating more strict#341
Merged
Merged
Conversation
Contributor
Author
|
sebastianbergmann/phpunit#5403 This is "interesting"... And of course I can't reproduce this locally!! 🎉 |
Contributor
Author
|
Ah figured it out. The |
sstok
force-pushed
the
feature/order-changes
branch
from
3585b8e to
d51bf58
Compare
Contributor
Author
|
Well that wasn't the problem then... as removing the custom error handler still makes things fail. |
sstok
force-pushed
the
feature/order-changes
branch
3 times, most recently
from
3009545 to
49279e8
Compare
- Require an associative array for `SearchOrder` (*old* structure still allowed) - More strict validation of correct structure - Soft deprecate `getValuesGroup()` in favor of getting fields (will be finally resolved in v3.0)
sstok
force-pushed
the
feature/order-changes
branch
from
49279e8 to
e8a5414
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SearchOrder(old structure still allowed)getValuesGroup()in favor of getting fields (will be finally resolved in v3.0)