Repository navigation
fix(auth): honour guest middleware under global auth middleware - #107
Merged
Merged
Conversation
guest was a documented no-op while global auth redirected every route except the login path. Auth middleware now treats route meta including 'guest' as public, uses the module default login path /auth/login, and preserves the full path (with query) in the post-login redirect.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
Aligns the middleware with fix/auth-redirect-validation so both branches make the identical change to this line and merge cleanly in either order. Comparing fullPath also means a home visit with a query string still round-trips that query through the post-login redirect.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
guestmiddleware was a documented no-op. WithenableGlobalAuthMiddleware: true, every route except the login path redirected to login — including pages markedmiddleware: 'guest'.Auth middleware also fell back to
/login(module default is/auth/login) and stored onlyto.path, dropping the query string from the post-login redirect.Fix
authmiddleware treats route meta that includesguestas public./auth/login.to.fullPathso query (and hash segment handling via fullPath) is preserved.guestcan bounce already-authenticated users off the login path to home.