feat: Phase 1 architecture stabilisation + test infrastructure#32
Merged
feat: Phase 1 architecture stabilisation + test infrastructure#32
Conversation
- Merge badge registries: engine.js imports from definitions.js; real emoji icons added (🎯🔥🚀🏀) - Extract useSessionData() hook: Dashboard 373 → 155 lines - Extract useAnalytics() hook: all analytics memos moved out of Dashboard - Extract lib/insights.js: pure typeLabel + generateInsights; InsightsSummaryCard is presenter-only - Add JSDoc @typedef for Session, Round, ZoneStat in models.js - Delete dead xpService.js (XP source of truth is session docs + xpCalculator.js) - Remove dead LogSection.jsx filter state (typeFilter/from/to) - Add firestore.rules + firebase.json (owner-only session + achievement access) - Analytics comparator: Auto/Prev/Last-active mode switch with always-visible baseline range label - Milestones UX: N/total category counters + next-tier dashed preview row per category - Navbar: non-admin dev tools hint; refresh-token note; dark mode dropdown text fix Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ght smoke test - Replace node --test with vitest run; add test:watch, test:ui, test:coverage, test:e2e scripts - Migrate all 7 existing test files from node:test/assert to Vitest expect syntax - Add vitest.config.js (happy-dom environment, globals, @vitejs/plugin-react) - Add src/test/setup.js (@testing-library/jest-dom) - Add src/components/SessionForm.test.jsx: 13 component tests covering all 3 form steps - Add playwright.config.js + e2e/dashboard.spec.js: 3 unauthenticated redirect smoke tests - Fix eslint.config.js: Node globals for *.config.js and e2e/** files - Suite: 44/44 unit+component tests; 3/3 E2E tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useSessionData+useAnalyticshooks extracted,lib/insights.jspure functions, JSDoc typedefs for core models, deadxpService.jsdeletednode --test→ Vitest (44/44);SessionFormcomponent test (13 cases); Playwright smoke test (3 E2E cases)Test plan
npm test→ 44/44 passnpm run lint→ cleannpm run build→ cleannpm run test:e2e→ 3/3 pass🤖 Generated with Claude Code