feat(storage): invalidate the cache on schema version change - #213
Merged
Merged
Conversation
The local SQLite database is retained between runs since #203, which means an entity change can leave the file holding tables the code no longer matches. Treat it as a cache rather than something to migrate: stamp the schema revision in PRAGMA user_version, and drop every table on a mismatch so init_schema rebuilds them from scratch. Tables are dropped rather than the file unlinked, since another running Terminalist process may still hold the file open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The local SQLite database is retained between runs since #203, which means an entity change can leave the file holding tables the code no longer matches. Treat it as a cache rather than something to migrate: stamp the schema revision in PRAGMA user_version, and drop every table on a mismatch so init_schema rebuilds them from scratch.
Tables are dropped rather than the file unlinked, since another running Terminalist process may still hold the file open.
Summary
Describe the changes and the motivation.
Changes
Checklist
cargo fmtpassescargo clippy -- -D warningspassescargo testpassesRelated issues
#203 && #209