chore(storage): restrict the cache file to its owner, drop dead tests - #215
Merged
Merged
Conversation
backends.credentials stores the API token as plaintext JSON, so the cache
is a credential file and has no business being world-readable. Set 0600
after connecting, best-effort: a filesystem without Unix modes logs a
warning instead of blocking startup.
Also delete tests/storage/{tasks,labels,projects,sections}.rs. Four
copies of the same test, asserting only that $HOME is writable, and
tests/storage.rs never declared them so they were not even compiled.
romaintb
force-pushed
the
chore/secure-db-file
branch
from
September 4, 2026 10:56
ac6b243 to
6e233d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backends.credentials stores the API token as plaintext JSON, so the cache is a credential file and has no business being world-readable. Set 0600 after connecting, best-effort: a filesystem without Unix modes logs a warning instead of blocking startup.
Also delete tests/storage/{tasks,labels,projects,sections}.rs. Four copies of the same test, asserting only that $HOME is writable, and tests/storage.rs never declared them so they were not even compiled.
Changes
Checklist
cargo fmtpassescargo clippy -- -D warningspassescargo testpassesRelated issues
Initialy done by @stevenwcarter in #209