Trim dependency features and uncalled code - #240
Merged
Merged
Conversation
tokio was on "full" for time, sync, spawn and join. sea-orm was on defaults, enabling bigdecimal, rust_decimal, time, chrono and serde_json integrations no entity uses, plus rustls for a local SQLite file. Drops 27 packages, 296 -> 279 crates. No source change.
init, handle_events, on_focus and on_blur had no call sites; callers reach for handle_key_events directly. Also ScrollbarHelper::state, needs_scrollbar's visibility, and one unreferenced constant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two independent cuts found while auditing dependency weight. No behaviour change.
Changes
Deps (no source change):
tokiowas on"full"fortime,sync,spawnandjoin.sea-ormwas on defaults, enabling bigdecimal, rust_decimal, time, chrono and serde_json integrations no entity uses, plus rustls for a local SQLite file. Drops 27 packages, 296 -> 279 crates.Dead code:
Component::init,handle_events,on_focusandon_blurhad no call sites; callers reach forhandle_key_eventsdirectly. AlsoScrollbarHelper::state,needs_scrollbar's visibility, and one unreferenced constant.Checklist
cargo fmtpassescargo clippy -- -D warningspassescargo testpasses