refactor: cut over-engineering from repo-wide audit - #243
Merged
Merged
Conversation
romaintb
force-pushed
the
chore/ponytail-audit-cuts
branch
2 times, most recently
from
September 7, 2026 11:26
898e7f1 to
5ee7d7c
Compare
- delete todoist re-export shim, import todoist_api directly - drop dead backends.is_enabled/settings columns (schema v2) - replace once_cell with std LazyLock (rust-version 1.80) - replace fern with a ~30-line log::Log impl (same memory buffer and file format) - replace hand-rolled weekday_name with chrono's Weekday Display Config note: rust-version bumped 1.78 -> 1.80 for LazyLock. Existing local caches rebuild automatically via the schema version bump.
romaintb
force-pushed
the
chore/ponytail-audit-cuts
branch
from
September 7, 2026 11:29
5ee7d7c to
ed140ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repo-wide over-engineering audit (ponytail-audit). Complexity cuts only — no behavior changes.
src/todoist.rsre-export shim — call sites nowuse todoist_apidirectlybackends.is_enabled/backends.settingscolumns (written, never read);SCHEMA_VERSIONbumped to 2 so existing caches rebuild automaticallyonce_cell→std::sync::LazyLock(also drops a pointlessArcaround the static)fern→ ~30-linelog::Logimpl; same in-memory buffer for the logs dialog and same[HH:MM:SS.mmm]file formatweekday_name()→ chrono's%AstrftimeThe multi-backend abstraction (Backend trait, factory, registry) was kept deliberately — it's the foundation for future providers.
Config / behavior notes
rust-versionbumped 1.78 → 1.80 (forLazyLock)discard_stale_schemamechanism)Verification
cargo build,cargo clippy --all-targets,cargo fmt --checkcleancargo test: all 54 tests passNet: -75 lines, -3 deps (
fern,once_cell, + transitive).