test(notification-service): cover payload cms validation and seeding - #2
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The SonarQube quality gate on main failed with 64.2% coverage on new code against the required 80%. The uncovered changes were concentrated in the notification service's Payload CMS migration.
Add 51 tests covering collection validation and audit hooks, environment configuration, and template seeding on empty/existing databases and error paths. The tests exercise the real collection hooks and seed entry point while mocking the external CMS boundary. No production code or coverage exclusions change.
Validation:
SonarQube's new-code gate still needs confirmation in CI; the local service line-coverage percentage is a separate metric.