fix(cli): preset notes per tool, extra-arg guard, per-command --help, real versions - #24
Merged
Conversation
…help, real versions - preset hardhat no longer carries the forge-only skip-simulation note - extra positional args error with the comma-separated-args hint instead of being silently dropped into a raw ABI length mismatch - rome <cmd> --help prints per-command usage + arg descriptions - CLI --version and MCP serverInfo read the version from package.json - facts programs testnet explains the empty set (settles on Solana devnet) - README: npx-first install; plain npm -g from a github: URL fails (git deps are prepared without their node_modules), documented clone+link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five small UX/correctness fixes surfaced by exercising every command against a live chain:
forge script --skip-simulationnote; notes are now tool-specific (shared Rome quirks + per-tool additions).rome call <chain> <addr> <sig> 0xA 0xBfed only0xAto the ABI encoder and surfaced as a raw viem params/values length mismatch. Now errors with the comma-separated-args hint and points at--help.rome <cmd> --helppreviously fell through to "Missing required: …"; now prints per-command usage, summary, and arg descriptions.rome --versionand MCP serverInfo were hardcoded to0.1.0; both now read the package.json version.rome facts programs testnetsilently returned{}; now carries a note that Rome testnet chains settle on the Solana devnet cluster.Also README: lead install with npx and document clone+link — a plain
npm install -g github:…fails because npm prepares the package'sgithub:dependencies without their own node_modules (see the companion issue).Tests: 8 new (107 total, all green); typecheck clean; all five fixes re-verified against the built
dist/bin.json a live chain.