Return repo information if the index is unreadable#419
Open
puqeko wants to merge 2 commits intoromkatv:masterfrom
Open
Return repo information if the index is unreadable#419puqeko wants to merge 2 commits intoromkatv:masterfrom
puqeko wants to merge 2 commits intoromkatv:masterfrom
Conversation
Treat an unreadable index as if option to ignore index computations was passed. Instead of reporting no-repo, basic repo info will be reported.
Add 30th entry to response which is 1 if index computations are disabled OR the index cannot be read, 0 otherwise. The requester, knowing the requests contents, can determine if the index could not be read while still receiving repository information that is avaliable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Less of a serious PR and more of a question, if the index is unreadable (ie
core.splitIndexis enabled) then why doesgitstatusreport no repo? It means that a command prompt won't show any information where it would have otherwise if the 'ignore index computations' option was given. Wouldn't it be a better user experience if we fall back to that instead?Changes
Tested on darwin-x86 only.
Thank you for this work. An inspirational read.