Repository navigation
fix: stabilize Windows discovery and reconcile adapter catalog - #7
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Code Review Roast 🔥Verdict: No Issues Found | Recommendation: Merge Oh wait, this PR is actually clean. I need to sit down. I had my flamethrower warmed up and everything. 📊 Overall: Like finding a unicorn in production — I didn't think clean PRs existed anymore, but here we are. Files Reviewed (3 files)
Previous Review Summary (commit a17869d)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit a17869d)Verdict: No Issues Found | Recommendation: Merge Oh wait, this PR is actually clean. I need to sit down. I had my flamethrower warmed up and everything. 📊 Overall: Like finding a unicorn in production — I didn't think clean PRs existed anymore, but here we are. Files Reviewed (18 files)
Reviewed by free · Input: 32K · Output: 1K · Cached: 166.1K |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a17869d957
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Windows PATH discovery could exceed the CLI plan test's unchanged 10-second deadline. Discovery now scans directory names once when possible, resolves with bounded concurrency when listing is denied, deduplicates probes and refreshes every request. Review identified that unset PATH must preserve the standard-library default search; the final revision bypasses the prefilter in that case and adds a regression test.
Catalog generation derives adapter flags from code-owned commands. Doctor/dashboard distinguish a detected frontend (r2) from its adapter executable (rabin2). Availability fields are additive; existing CLI/MCP names and evidence formats remain compatible. Canonical links and current capability docs are repaired; CI checks catalog regeneration.
Final local verification: Windows 11 / CPython 3.14.7, 60 tests in 33.735 seconds, 59 passed and one skipped (file absent). Eight discovery tests; coverage.py 7.11.0 reports 100% of discovery.py statements/branches (31 statements, 12 branches), not whole-project coverage. All 12 skills validated. Wheel rebuilt after the review fix and its bundled catalog loaded successfully. External-provider E2E and general performance benchmarks remain unverified. Exact-head remote CI is required before merge.
GitHub About and 12 accurate Topics were applied and read back. docs/STABILIZATION.md records baseline evidence, reviewed open PRs, remaining risks and executable milestone tasks. PR #6 remains separate for tighter electronics record contracts; PR #4 upstream is not automatically merged. No release published.