[IR-4340] Fix incidents get failing on labels parsing#8
Merged
Conversation
The Rootly API returns labels as an empty object {} when there are no
labels, but the Go struct expected an array []. Added flexibleLabels
custom type with UnmarshalJSON that handles both formats.
Fixes IR-4340
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rootly incidents get <id>failing withjson: cannot unmarshal object into Go struct field ... of type []struct"labels":{}(empty object) when no labels exist, but the CLI expected"labels":[](array)flexibleLabelscustom type withUnmarshalJSONthat handles both array and object formatsLinear Issue
https://linear.app/rootly/issue/IR-4340
Test Plan
flexibleLabels(array, empty object, object with keys)rootly incidents get <id>with an incident that has empty labelsrootly incidents get <id>with an incident that has labels as array