making the default method with no parameters supplied be a single type#31
Open
rmflight wants to merge 1 commit intoropensci:masterfrom
Open
making the default method with no parameters supplied be a single type#31rmflight wants to merge 1 commit intoropensci:masterfrom
rmflight wants to merge 1 commit intoropensci:masterfrom
Conversation
…e so the switch statement work properly
Contributor
|
Why not TYPE_9_16? |
Author
|
I truly just picked one. I'll be honest, I'm just a user, I haven't followed the literature in this space, I think I just picked the first one in the list to use. If there is a better default, then it should be used instead. I'm fine with changing the default. |
4883ccf to
cee9805
Compare
19501e3 to
fad1fb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you don't specify the method when calling
ocv_keypoints, it currently fails because there are multiple inputs to the switch statement