Repository navigation
66 working with segments vignette - #76
Merged
Merged
Conversation
temospena
commented
Jun 16, 2026
| # Load example data | ||
| data(lisbon_route) | ||
| dem_lisbon = dem_lisbon() | ||
| dem_lisbon <- dem_lisbon() |
Collaborator
Author
There was a problem hiding this comment.
these operator changes are annoying. please ignore.
Robinlovelace
approved these changes
Jun 16, 2026
| } | ||
| n <- nrow(routes) | ||
| linestrings <- lapply(seq(n), function(i) sf::st_linestring(m_xyz[m[, 3] == i, ])) | ||
| linestrings <- lapply(seq(n), function(i) sf::st_linestring(m_xyz[m[, "L1"] == i, ])) |
Member
There was a problem hiding this comment.
Would this be more specific and clear, seeing as we want a vector output?
Suggested change
| linestrings <- lapply(seq(n), function(i) sf::st_linestring(m_xyz[m[, "L1"] == i, ])) | |
| linestrings <- lapply(seq(n), function(i) sf::st_linestring(m_xyz[m[["L1"]] == i, ])) |
Not tested but imagine it should work..
Collaborator
Author
There was a problem hiding this comment.
yes, for a data.frame. but this is a matrix (from st_coordinates()), right? not sure if works the same way...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed:
m[, "L1"]— uses the named column, which correctly holds the feature row index.The vignette now has two subsections under "Working with segments":
route_to_segments(), one segment per coordinate pair → finer resolution, follows the exact linestring geometrystplanr::line_segment(100), thenelevation_add()→ coarser, user-controlled granularity