Skip to content

Fix resolve IP feature #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
snovvcrash wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix resolve IP feature #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
388ebed
Add cyrillic name for DA group
snovvcrash May 26, 2021
c502994
Fix resolve IP feature
snovvcrash May 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions windapsearch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
"Domain-Admins",
"Domänen Administratoren",
"Domänen-Administratoren",
"Администраторы домена",
"Администраторы-домена",
]

# Privileged builtin AD groups relevant to look for
Expand Down Expand Up @@ -377,7 +379,7 @@ def getComputerDict(self, computerResults, ipLookup=False):
computerInfo = {}
dn = computer.dn
for attr in computer.get_attr_names():
computerInfo[attr] = ','.join(computer.get_attr_values(attr))
computerInfo[attr] = ','.join([val.decode() for val in computer.get_attr_values(attr)])

if 'dNSHostName' in computerInfo:
hostname = computerInfo['dNSHostName']
Expand Down Expand Up @@ -487,7 +489,7 @@ def prettyPrintDictionary(results, attrs=None, separator=","):
'operatingSystemServicePack']
attrs = []

for dn, computer in results.iteritems():
for dn, computer in results.items():
for key in computer:
keys.add(key)

Expand Down