Fix moved preview metadata that broke Windows CI - #24
Open
rorohecker wants to merge 6 commits into
Open
rorohecker wants to merge 6 commits into
rorohecker wants to merge 6 commits into
Conversation
set_preview_meta took ownership of base_meta, then the Windows shell-thumbnail thread tried to clone it. Keep the string for both. Co-authored-by: rsn597 <rsn597@my.utexas.edu>
rorohecker
marked this pull request as ready for review
September 10, 2026 23:32
Fail the Release workflow before NSIS/WiX so a compile error cannot spend 15+ minutes packing and still leave /releases/latest without installers. Install the clippy component on CI as well, and allow a manual Release dispatch that attaches new installers to an existing tag. Co-authored-by: rsn597 <rsn597@my.utexas.edu>
Release still packs on version tags and on manual dispatch. A main push now packs only when that Cargo.toml version already has a git tag but the GitHub release has no .exe/.msi assets, so merging the v1.0.18 compile fix publishes the installers without rebuilding every later main commit. Co-authored-by: rsn597 <rsn597@my.utexas.edu>
The previous decide job never parsed (0s, no jobs). Drop the unused dispatch input and the Python heredoc so check/clippy still run before pack, and a main merge can still publish the missing v1.0.18 installers. Co-authored-by: rsn597 <rsn597@my.utexas.edu>
The v1.0.18 tag exists but has no installers, and this agent cannot merge to main or dispatch Actions. Allow this already-green branch to pack so check and clippy still run before NSIS/WiX, then attach the missing assets to v1.0.18. Co-authored-by: rsn597 <rsn597@my.utexas.edu>
v1.0.18 exe and msi are published, so the temporary on.push.branches entry is no longer needed. Co-authored-by: rsn597 <rsn597@my.utexas.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.0.18 fails
cargo checkand the Windows installer on the same E0382:The media preview path moves
base_metainto the UI, then the Windows-only shell-thumbnail thread clones it. Linux hid this because that block iscfg(windows).This clones before the first
set_preview_metaso both the pane and the thumbnail task keep the string.After merge, re-run the v1.0.18 Release workflow so the installers publish.