-
Notifications
You must be signed in to change notification settings - Fork 187
Derive macro for StructuredParameters #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This way they can remain part of the crate without breaking other ros package builds Other packages can load the dependency through cargo
remove -e flag from echo to not add it to bashrc
esteve
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@balthasarschuess @BCSol thanks for the PR, it doesn't seem necessary to have a separate crate only for the macros, can you move that into rclrs? Thanks.
Hey @esteve :) I might be mistaken, but I could not find any resource claiming that this restriction has been lifted. |
Proposal for structured parameters derive macro (#496)
Changes:
StructuredParametersrclrs_proc_macrostest_msgsandexample_messageswith apt, without the cargo build without colon would fail to link rosidl message (I'd be happy about some help there)TODO:
NodeState/Node@mxgrey before I continue here, I'd be happy about some feedback, whether this is what you had in mind or how we could improve upon this POC.