Demo: annotating hand edits to an importer-generated CSV namespace - #483
Open
SimonCockx wants to merge 1 commit into
Open
SimonCockx wants to merge 1 commit into
SimonCockx wants to merge 1 commit into
Conversation
SimonCockx
force-pushed
the
demo/csv-import-annotation-demo
branch
2 times, most recently
from
July 28, 2026 10:45
d20b76b to
231ffa2
Compare
Rename the trading date/time column label to match the source file and document the matched-principal trading capacity.
SimonCockx
force-pushed
the
demo/csv-import-annotation-demo
branch
from
July 28, 2026 12:43
231ffa2 to
5414301
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Illustration only — not intended to merge. Raised to show what the annotate, don't block guard looks like on a real pull request, for the STORY-1911 CSV import design.
Setup (on the base branch, not in this diff)
demo.unavista.csvis an example namespace of the kindmodel-importwould generate from CSV samples. Itsrune-config.ymlentry carries an origin marker and is deliberately not read-only:A new workflow,
annotate-generated-namespaces.yml, reports on pull requests that touch such namespaces. It never fails — refining a generated model by hand is the intended workflow, so a blocking check would put a bypass label on nearly every PR and the signal would decay into a ritual.What this PR changes
Two ordinary refinements a modeller would make after an import:
unavista-csv-type.rosetta[label]ontradingDateTimeto match the source column, and documents itunavista-csv-enum.rosettaMTCHThe label change is raised to warning because the CSV column binding depends on labels — that is the class of edit that can silently break ingestion. Documentation changes stay at notice level, so the warning keeps its meaning.
What to look at
Note: the model omits a
schema <name> CSVdeclaration, since this repo is on DSL 10.2.0 which predates that construct.