Revert the pom.xml URL change and pin gcp-oidc-auth 1.0.1 - #506
Closed
Chuks-Ajeh wants to merge 1 commit into
Closed
Chuks-Ajeh wants to merge 1 commit into
Chuks-Ajeh wants to merge 1 commit into
Conversation
The OIDC migration that landed here also rewrote the pom's artifactregistry:// URLs to https://. On review feedback that part is not wanted, so pom.xml goes back to its pre-migration state; the wagon extension it already had stays. 1.0.1 of the step reports which of the three federation calls was refused, rather than failing opaquely.
Contributor
Author
|
Closing: the pom format that landed here is the one we want after all - all Artifact Registry URLs on https with the wagon kept. Superseded by a PR that only pins the step to 1.0.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OIDC migration that landed in this repository also rewrote the pom's
artifactregistry://URLs tohttps://. On review feedback that part is not wanted, sopom.xmlgoes back to its pre-migration state — theartifactregistry-maven-wagonextension it already carried is unaffected. The step is also pinned toregnosysops/gcp-oidc-auth:1.0.1, which reports which of the three federation calls was refused instead of failing opaquely.Worth a reviewer's attention before merging: with the pom back on
artifactregistry://, resolution and deployment go through the wagon, which authenticates only through Application Default Credentials — and the pipeline no longer writes a credentials file, because that was the service account key this migration removed. The migration runbook notes the same thing in its troubleshooting section:artifactregistry://entries "logNo credentials could be foundbecause the Maven image has nogcloud".settings.xmlsuppliesGCP_ACCESS_TOKENas a Basic auth password, which the wagon does not read.The reference implementation does not settle this either way:
rosetta-productshas nodistributionManagementand never runsmvn deploy, so the runbook has no guidance for a repository that publishes.