Inherit#2
Open
rosshendrickson-wf wants to merge 11 commits into
Open
Conversation
There was a problem hiding this comment.
Should we make this config options of some sort?
There was a problem hiding this comment.
Yeah, this should probably be configurable in furious.yaml.
|
@tannnermiller-wf @tylertreat-wf @johnlockwood-wf can you give this a look |
There was a problem hiding this comment.
Import ordering should be alphabetical :)
|
Looks good besides the minor comments. |
There was a problem hiding this comment.
It's not clear how demonstrating the new inheritance behavior provides any value to the end user. Why do they care?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses concerns over completion checks and cleanup tasks occurring in the default queue in BigSky. Cleanup tasks now go to a 'clean' queue (name is open to debate, maybe slow). The completion checks will inherit the queue that the tasks added to the context are running in. This is a subtle difference than inheriting the queue that the context itself is created in and allows greater freedom to shard async's across different queues and balance out their own performance. It was also easier to implement so there is that. This PR is for soliciting feedback. After we're happy I'll do a real CR against Webfilings Master. There will also have to be a single BigSky PR to add the clean queue. Dave said he's ok with that and that he is fine with completions being in the default queue if they do not set their asyncs up correctly because then they can fix it themselves instead of creating a fallback queue for furious completion tasks.