Skip to content

feat: Add annotation processing duration endpoint field duration_late…#149

Merged
stancld merged 2 commits intorossumai:mainfrom
username-still-not-available:rl-annotation-processing-duration-latest-validate-started
Mar 10, 2026
Merged

feat: Add annotation processing duration endpoint field duration_late…#149
stancld merged 2 commits intorossumai:mainfrom
username-still-not-available:rl-annotation-processing-duration-latest-validate-started

Conversation

@username-still-not-available
Copy link
Collaborator

…st_validate_started

@username-still-not-available username-still-not-available force-pushed the rl-annotation-processing-duration-latest-validate-started branch 2 times, most recently from 98f198e to 7094b65 Compare March 10, 2026 10:30
build_resource_processing_duration_url(Resource.Annotation, annotation_id),
)
return AnnotationProcessingDuration(**data)
return dacite.from_dict(AnnotationProcessingDuration, data, config=DACITE_CONFIG)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should use self._deserializer approach.

@username-still-not-available username-still-not-available force-pushed the rl-annotation-processing-duration-latest-validate-started branch from 7094b65 to 1b7a891 Compare March 10, 2026 10:48
Radek Ludacka added 2 commits March 10, 2026 11:53
Replace direct **data unpacking with self._deserializer so that unknown
fields returned by the API are silently ignored instead of raising
TypeError. Add AnnotationProcessingDuration to Resource enum and
RESOURCE_TO_MODEL mapping.
Add duration_latest_validate_started and
duration_latest_validate_updated_before_confirm nullable fields
to AnnotationProcessingDuration model per the API specification.
@username-still-not-available username-still-not-available force-pushed the rl-annotation-processing-duration-latest-validate-started branch from 1b7a891 to e981c15 Compare March 10, 2026 10:57
@stancld
Copy link
Contributor

stancld commented Mar 10, 2026

Lgtm

@stancld stancld self-requested a review March 10, 2026 11:02
Copy link
Contributor

@stancld stancld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@stancld stancld merged commit 2a2148b into rossumai:main Mar 10, 2026
10 checks passed
@username-still-not-available username-still-not-available deleted the rl-annotation-processing-duration-latest-validate-started branch March 10, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants