Fix Xiaomi haptic feedback crash#374
Merged
Merged
Conversation
Add the VIBRATE permission and guard View.performHapticFeedback so Xiaomi/Android 16 devices do not crash when haptic feedback reaches the vibrator service without permission. Reported by A**** K***.
There was a problem hiding this comment.
Pull request overview
This PR fixes a haptic feedback crash path by declaring vibration permission and safely handling denied haptic feedback calls while preserving cooldown behavior.
Changes:
- Adds
android.permission.VIBRATEto the app manifest. - Wraps haptic feedback execution in a
SecurityExceptionguard. - Adds unit coverage for denied permission and delegate return behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
app/src/main/AndroidManifest.xml |
Declares vibration permission required by haptic feedback paths. |
app/src/main/java/me/rosuh/easywatermark/utils/VibrateHelper.kt |
Adds safe haptic feedback execution and makes cooldown timestamp updates effective. |
app/src/test/java/me/rosuh/easywatermark/utils/VibrateHelperTest.kt |
Adds regression tests for the safe haptic feedback helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release note
Test plan