Conversation
- ViewFactorKernel/GPUKernels: correct the 13-point Dunavant degree-7 triangle rule. It had a positive centroid weight (should be negative) and reused the general orbit's beta as a bogus symmetric orbit, missing the beta=0.260346 orbit entirely; the prior weight tweak made the sum 0.5 but broke degree-7 exactness. - GPUKernels: fix VF double-integral loop bounds. They used "fi == 0 ? nq : nqt", treating only quad8 as a quad, so quad4 (family 2) ran the triangle point count over Gauss points, making the integral ~10x low and diverging with nquad. Now "(fi == 0 || fi == 2)" to match the area loop. - runtests: qualify load_vtu as RadiativeViewFactor.MeshIO.load_vtu so the test exercises the intended ErrorException instead of UndefVarError. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…e, added benchmarks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drastically optimized execution time and allocation size by pre-computing the ray-trace