refactor check for non-empty workdir by umlaeute · Pull Request #393 · roundcube/roundcubemail-docker

umlaeute · 2025-12-17T14:23:07Z

introduce new envvar ROUNDCUBEMAIL_ALLOW_DIRTY_DOCROOT, which can be truish, falsish or empty:

value	result
`true`	skip checks for empty docroot
`false`	abort if docroot is not empty
(empty)	if the docroot is not empty, print a warning and sleep, giving the user the chance to manually abort.

this keeps backwards compatibility with existing deployments (that do not have the envvar set)

the sleep timeout has been raise to 60seconds, so the user has more time to manually abort (in an autostart context, this will add an additional delay, but shouldn't actually be harmful)

Closes: wishlist: make timeout on non-empty workdir configurable #384
obsoletes: raise severity of non-empty docroot test #387

introduce new envvar ROUNDCUBEMAIL_ALLOW_DIRTY_DOCROOT if it is true, skip checks for empty docroot. if it is false and the docroot is not empty, abort. if it is empty and the docroot is not empty, print a warning and sleep, giving the user the chance to manually abort. this keeps backwards compatibility with existing deployments (that do not have the envvar set) the sleep timeout has been raise to 60seconds, so the user has more time to manually abort (in a autostart context this will add an additional delay, but shouldn't actually be harmful) Closes: roundcube#384

pabzm · 2025-12-18T16:28:17Z

I like this idea, thank you!

Just one thing: could you reduce the "penalty" timeout back to 10 seconds? Because even that change might break setups if a system takes much longer to start than expected.

And from my point of view I would reduce the possible truthy and falsy values. Using "yes" and "no" should be enough and makes for more clear documentation, too. But I won't force that if you care strongly about it.

github-actions · 2026-01-02T00:46:17Z