Skip to content

Fix permissions of add_assignee_to_pr.yml#19

Merged
masutaka merged 1 commit into
mainfrom
fix-permissions
May 17, 2024
Merged

Fix permissions of add_assignee_to_pr.yml#19
masutaka merged 1 commit into
mainfrom
fix-permissions

Conversation

@masutaka

@masutaka masutaka commented May 17, 2024

Copy link
Copy Markdown
Contributor

変更概要

add_assignee_to_pr.yml に permissions を追加します。

PR #3 で追加されるはずが、結果的に追加されなかったようです。

🔗 https://github.com/route06/actions/pull/3/commits

  1. 8cd205e
    • 関係ない変更
  2. 5a3edc5
    • _add-assignee-to-pr.yml から permissions 設定削除 ← ❓
    • add-assignee-to-pr.yml に permissions 設定追加 ✅
  3. cb91130
    • 関係ない変更
  4. bf99edc
    • 関係ない変更
  5. f2eb165
    • add-assignee-to-pr.yml を setup-pr.yml にリネーム ← ここ ⚠️

補足

technote-space/assign-author#261 がマージされれば、permissions は不要です。
良く見たら、README.md の変更なので間違い。

@masutaka masutaka changed the title Fix permissions of add_assignee_to_pr.yml Fix permissions to add_assignee_to_pr.yml May 17, 2024
@masutaka masutaka marked this pull request as ready for review May 17, 2024 08:00
@masutaka masutaka requested a review from a team as a code owner May 17, 2024 08:00
@masutaka

Copy link
Copy Markdown
Contributor Author

@MH4GF レビューをお願いします!🙏

@masutaka masutaka changed the title Fix permissions to add_assignee_to_pr.yml Fix permissions of add_assignee_to_pr.yml May 17, 2024

@MH4GF MH4GF left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なるほど、追加漏れですね 🙏🏻
ご対応ありがとうございます、よさそうですー!
releaseも合わせてお願いします!

@masutaka masutaka merged commit 809c36d into main May 17, 2024
@masutaka masutaka deleted the fix-permissions branch May 17, 2024 08:20
@masutaka

Copy link
Copy Markdown
Contributor Author

ありがとうございます! v2.0.1 のリリースと v2 タグの更新をしました。

@MH4GF

MH4GF commented May 17, 2024

Copy link
Copy Markdown
Contributor

ありがとうございます 🚀🚀🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants