Skip to content

Add macrocycle preset, low mode following, macrocyclic amide flip#3

Merged
ncasetti7 merged 4 commits into
masterfrom
feat/low-mode-following
Jun 16, 2026
Merged

Add macrocycle preset, low mode following, macrocyclic amide flip#3
ncasetti7 merged 4 commits into
masterfrom
feat/low-mode-following

Conversation

@ncasetti7

Copy link
Copy Markdown
Contributor

@corinwagen Implemented low mode following and macrocyclic amide flips as well as added a macrocycle setting preset. All tests and docs should be updated as well.

@ncasetti7 ncasetti7 requested a review from corinwagen June 15, 2026 18:12

@corinwagen corinwagen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Comment thread openconf/data/runtime_tuning.json Outdated
"crankshaft": 0.06,
"ring_kic": 0.06
"ring_kic": 0.06,
"amide_flip": 0.06

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bro these were normalized to 100 before

Comment thread openconf/propose/low_mode.py Outdated
entries, skips all modes up to that boundary, and returns eigenvectors
whose eigenvalues are below eigenvalue_threshold, capped at max_modes.

Using a gap rather than a fixed count of 6 handles linear molecules

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never seen this approach before! Usually I just project out the rotational/translational modes

@ncasetti7 ncasetti7 merged commit 00e131d into master Jun 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants