Repository navigation
Tidy the title bar, How it works, compare table, dialogs and phone year slider - #9
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Use the cards' own 16px inset on both sides. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
roxburghm
changed the title
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-forest-0ca6e1603-9.westeurope.3.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-forest-0ca6e1603-9.westeurope.3.azurestaticapps.net |
- Title bar: "Ealing secondary school places" with a one-line explanation, a small mark, and proper "Compare schools" / "How it works" buttons (phones: "Ealing school places" with the same two icon buttons). Page title to match - How it works: rewritten as short sections (what the rings mean, with the map symbols; how chances are worked out, as a key; distance; schools with extra rules; Ofsted; sources by year; privacy), in the app's own styling - Compare table: fits the dialog (short school names with the full name on hover, Ofsted labels can wrap, body scrolls rather than spilling out), uses the same mini charts as the list and the app's colours, and explains the cell shading Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
roxburghm
changed the title
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-forest-0ca6e1603-9.westeurope.3.azurestaticapps.net |
"How it works" filled almost the full window height. Cap both desktop dialogs at min(760px, 100vh - 128px) via the dialog's own max-height (CSS on the card lost to Vuetify's dialog styles); content scrolls inside. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-forest-0ca6e1603-9.westeurope.3.azurestaticapps.net |
Replaces the year drop-down with the same slider as desktop, under the List / Map switch, and adds one under the school name on a school's page so the chart, year sentence and map ring can be scrubbed there too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
roxburghm
changed the title
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-forest-0ca6e1603-9.westeurope.3.azurestaticapps.net |
The list's verdicts already cover every year; the slider stays on the Map tab and on each school's page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-forest-0ca6e1603-9.westeurope.3.azurestaticapps.net |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Title bar: "Ealing secondary school places" with a one-line explanation ("How close did you need to live to get a place? Cut-off distances for every school, 2019–2026."), a small mark, and proper Compare schools / How it works buttons. On phones: "Ealing school places" with the same two icon buttons. The browser tab title matches.
How it works: rewritten as short sections:
Restyled to match the rest of the app.
Compare table: now fits the desktop dialog; the 2026 column was being cut off. It uses short school names (full name on hover), lets Ofsted labels wrap, and scrolls inside the dialog rather than spilling out. It uses the same mini charts as the list and explains the cell shading.
Desktop dialogs: capped at min(760px, window − 128px), so How it works no longer fills the window top to bottom.
Phones: the year drop-down is replaced by the year slider (under List | Map), and each school's page has a slider under its name that updates the chart, year sentence and map.
List notes: the notes under the school list use the cards' 16px inset, so they line up with the dots.
Test plan
yarn build🤖 Generated with Claude Code