fix: improve mobile alert details and notification navigation - #90
Closed
CoooderSan wants to merge 4 commits into
Closed
CoooderSan wants to merge 4 commits into
CoooderSan wants to merge 4 commits into
Conversation
Member
|
Thanks for the PR — the mobile alert details and PWA navigation improvements look useful, and the overall direction makes sense. Before we merge this, please rebase the work onto the current For IncidentRelay 2.3 we are currently doing a breaking AlertGroup/Incident API split, so
to:
Please:
There are also a few things worth fixing while rebasing:
Once the PR is recreated against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve the mobile alert-details experience and the notification deep-link flow.
Testing
pytest -q tests/release/test_pwa_notification_navigation.py— 6 passedContributor License Agreement
After opening this pull request, comment exactly:
/sign-claYou only need to sign once per CLA version. If you already accepted the current
CLA.md, theCLAstatus check will pass automatically.