Make Add Business location editable while preserving reverse-geocode autofill#76
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
0ec6a8c
into
claude/blackmass-corporate-website-caGTR
3 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
addressInputstate and wired it to an editableInputfield so the Location is now a standard text input (type="text").addressInputwhenreverseGeocodesucceeds and falling back to an empty string when it fails.addressInput.trim() || nullinstead of the previous read-onlyaddressvalue and resetaddressInputon dialog open/close.setAddressInput(resolved ?? "")) to satisfy TypeScript and avoid runtime nulls.Testing
pnpm -s exec tsc --noEmit, which completed successfully.Codex Task