Repository navigation
feat: Compound Stork Oracle - #33
Merged
Merged
Conversation
AmanRaj1608
approved these changes
Sep 10, 2026
| updatedAt = uint256(report.timestampNs) / _NANOSECONDS_PER_SECOND; | ||
| require((updatedAt + _stalenessThresholdSeconds) >= block.timestamp, STALE_STORK_PRICE(_id)); | ||
| // A publisher clock ahead of the chain must never report a future update: the entry point's gate would open early | ||
| if (updatedAt > block.timestamp) updatedAt = block.timestamp; |
Collaborator
There was a problem hiding this comment.
should make this as if updatedAt > block.timestamp revert. cause if the stork oracle sets a future time stork will appear newly updated on every call
Collaborator
There was a problem hiding this comment.
Mainly because if this happens the queued trx can execute using unchanged stale price
ShivaanshK
self-requested a review
September 10, 2026 19:10
ShivaanshK
approved these changes
Sep 10, 2026
AmanRaj1608
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.