Skip to content

feat: Compound Stork Oracle - #33

Merged
ShivaanshK merged 6 commits into
mainfrom
feat/compound-stork-oracle
Sep 22, 2026
Merged

ShivaanshK merged 6 commits into
mainfrom
feat/compound-stork-oracle

Conversation

@ankurdubey521

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread src/oracle/StorkPriceOracle.sol Outdated
updatedAt = uint256(report.timestampNs) / _NANOSECONDS_PER_SECOND;
require((updatedAt + _stalenessThresholdSeconds) >= block.timestamp, STALE_STORK_PRICE(_id));
// A publisher clock ahead of the chain must never report a future update: the entry point's gate would open early
if (updatedAt > block.timestamp) updatedAt = block.timestamp;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should make this as if updatedAt > block.timestamp revert. cause if the stork oracle sets a future time stork will appear newly updated on every call

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly because if this happens the queued trx can execute using unchanged stale price

@ShivaanshK
ShivaanshK self-requested a review September 10, 2026 19:10
@ShivaanshK
ShivaanshK merged commit 866a844 into main Sep 22, 2026
1 check passed
@ankurdubey521
ankurdubey521 deleted the feat/compound-stork-oracle branch September 24, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants