Add Hours/bindEnglishTo and fix for words being zero#7
Add Hours/bindEnglishTo and fix for words being zero#7WadeTheFade wants to merge 5 commits intoroydanenterprises:developfrom
Conversation
|
I've found an issue with bindEnglishTo when selecting different scheduleTypes. There are a few different approaches to fixing.. my first impression is to only call toEnglishString() is validate passes. I'll try to address this and the failing checks in the next commit. |
|
This looks good. Would it be possible to get some unit tests wired up to test the new hourly options as well? I would want to make sure that especially the cron output is what we would expect for a given combinations of options (and vice versa, a provided cron string updates the DOM with the correct options). |
|
Yeah there is a bug in the monthly/yearly selection when bindEnglishTo() when loading a default schedule that isn't monthly/yearly: I'll try to address this and the unit tests around hourly soon |
resolves #3 and adds #5 and #6
I got it working, but was unable to resolve the testing.
Merging to develop in case someone can address before I get a chance.