Skip to content

[WIP] Fix code based on review comment 3582354834 - #6

Closed
rozensoftware with Copilot wants to merge 1 commit into
masterfrom
copilot/fix-review-comment-3582354834
Closed

[WIP] Fix code based on review comment 3582354834#6
rozensoftware with Copilot wants to merge 1 commit into
masterfrom
copilot/fix-review-comment-3582354834

Conversation

Copilot AI commented Jul 14, 2026

Copy link
Copy Markdown
  • Remove XREF current_key and XDEF EditBoxPollKey from lib/gui.s
  • Remove the EditBoxPollKey function body from lib/gui.s
  • Create new lib/gui_keyboard.s containing only EditBoxPollKey (with its own XREF current_key and XREF EditBoxProcessKey)
  • Update lib/gui.i comment to note EditBoxPollKey is in gui_keyboard.s
  • Add gui_keyboard.s to scripts/build_example.sh (LIB_SOURCES, ORDERED_LIBS, dependency closure)
  • Update docs/GUI_LIBRARY.md build integration section to mention gui_keyboard.s

@rozensoftware
rozensoftware marked this pull request as ready for review July 14, 2026 20:36
Copilot AI review requested due to automatic review settings July 14, 2026 20:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@rozensoftware
rozensoftware deleted the copilot/fix-review-comment-3582354834 branch July 14, 2026 20:37
Copilot stopped work on behalf of rozensoftware due to an error July 14, 2026 20:37
Copilot AI requested a review from rozensoftware July 14, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants