Skip to content

improvement: Create migration instance using ActivatorUtilities #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rpallares merged 1 commit into from
Jun 17, 2025
Merged

improvement: Create migration instance using ActivatorUtilities #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions Mongo.Migration/Migrations/Locators/MigrationLocator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,21 +107,7 @@ private static List<Assembly> GetAssemblies()

private TMigrationType GetMigrationInstance(Type type)
{
ConstructorInfo[] constructors = type.GetConstructors();

if (constructors.Length > 0)
{
var args = constructors
.First()
.GetParameters()
.Select(parameterInfo => _serviceProvider.GetRequiredService(parameterInfo.ParameterType))
.ToArray();

return Activator.CreateInstance(type, args) as TMigrationType
?? throw new InvalidOperationException($"Cannot create {type} migration");
}

return Activator.CreateInstance(type) as TMigrationType
return ActivatorUtilities.CreateInstance(_serviceProvider, type) as TMigrationType
?? throw new InvalidOperationException($"Cannot create {type} migration");
}
}