Initial commit: Gleisnetz-Editor JavaFX application

[rradica]

Summary

This is the initial commit of Gleisnetz-Editor, a JavaFX desktop application for editing topological rail networks. The application allows users to create and manipulate track nodes, edges, and edge-referenced domain data (signals) using a canvas-based editor with a toolbar-driven tool system.

Key Changes

• Domain Model (model package)

  • TrackNode, TrackEdge, Signal — immutable/semi-mutable domain entities with auto-generated sequential IDs
  • TrackNetwork — container managing nodes, edges, and signals with validation
  • EdgeRef — immutable linear-reference value object (edge + position + side) for positioning fachdaten
  • Side enum — LEFT/RIGHT relative to edge direction
  • SampleNetworks — factory providing a schematic Swiss rail network demo

• Geometry (geometry package)

  • Vec2 — minimal immutable 2D vector
  • Geometry — pure static methods for linear referencing: point interpolation, nearest parameter on segment, perpendicular offset for signal placement
  • All geometry is UI-free and fully unit-tested

• View Layer (view package)

  • NetworkEditorController — handles tool selection (SELECT/NODE/EDGE/SIGNAL), mouse input, and transient editing state (dragged node, pending edge)
  • NetworkRenderer — renders the network onto a JavaFX Canvas with color-coded nodes, edges, and signals
  • FXML layout (network-editor.fxml) with toolbar, canvas, and status bar
  • Dark theme CSS (styles.css)

• Application Entry Point

  • App — bootstraps JavaFX, loads FXML, and displays the editor window

• Testing

  • Comprehensive unit tests for domain model (TrackNetworkTest, TrackElementsTest, SignalTest, EdgeRefTest, SampleNetworksTest)
  • Geometry tests (GeometryTest) validating linear-reference math
  • All tests in src/test/java mirroring package structure

• Build & Quality

  • Maven pom.xml with JavaFX 21, JUnit 5, and quality plugins
  • Checkstyle guardrails: max 3 method parameters, max 500 LOC per class
  • PMD for dead code and bug patterns
  • SpotBugs for bytecode analysis
  • JaCoCo coverage gate (80% minimum on domain/geometry)
  • Module descriptor (module-info.java) with proper FXML opens and exports

• Documentation

  • AGENTS.md — comprehensive guidance for AI coding agents on architecture, conventions, and guardrails

Notable Implementation Details

• Separation of Concerns: Model and geometry packages have zero JavaFX imports, ensuring domain logic is testable without the toolkit. Only the view package imports JavaFX.
• Linear Referencing: Signals are positioned on edges via a relative parameter (0.0–1.0) and side, so they automatically stay correct when nodes move.
• Tool-Driven Interaction: The editor uses a toolbar-selected tool pattern (SELECT/NODE/EDGE/SIGNAL) that translates mouse clicks into model operations.
• Immutable Value Objects: Vec2 and EdgeRef are records with no side effects, keeping geometry pure and testable.
• Guardrails Enforced: Checkstyle and PMD are configured to fail the build on violations, ensuring methods stay focused and classes stay small.

https://claude.ai/code/session_019dPnZoRJALVs9vRd9i1MPH

[gemini-code-assist]

Code Review

This pull request introduces the Gleisnetz-Editor, a JavaFX desktop application for drawing topological rail networks, complete with domain models, geometry utilities, unit tests, and a Maven build configuration with quality tooling (Checkstyle, PMD, SpotBugs, JaCoCo). Feedback on the changes highlights several improvements: fixing the canvas resizing logic to allow the window to shrink, restricting mouse interactions to the primary button, safely handling potentially missing nodes in the controller to prevent crashes, and validating against self-loop edges in the network model.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

Binding the width and height of a standard Canvas directly to its parent Pane's properties prevents the parent pane from shrinking. In JavaFX, a Canvas is not resizable by default, so its size is treated as a hard minimum constraint during layout passes once it has grown. To allow the window and canvas to shrink properly, use listeners on the parent pane's dimensions to manually update the canvas size and trigger a redraw.

Suggested change

	canvas.widthProperty().bind(canvasHolder.widthProperty());
	canvas.heightProperty().bind(canvasHolder.heightProperty());
	canvas.widthProperty().addListener((obs, old, now) -> redraw());
	canvas.heightProperty().addListener((obs, old, now) -> redraw());
	canvasHolder.widthProperty().addListener((obs, old, now) -> {
	canvas.setWidth(now.doubleValue());
	redraw();
	});
	canvasHolder.heightProperty().addListener((obs, old, now) -> {
	canvas.setHeight(now.doubleValue());
	redraw();
	});

[gemini-code-assist]

The onMousePressed handler currently reacts to any mouse button press (including right-clicks and middle-clicks). This can lead to accidental node, edge, or signal creation when the user is trying to perform other actions (like opening a context menu). It is safer to restrict these tool interactions to the primary (left) mouse button.

    private void onMousePressed(MouseEvent event) {
        if (event.getButton() != javafx.scene.input.MouseButton.PRIMARY) {
            return;
        }
        double x = event.getX();
        double y = event.getY();

[gemini-code-assist]

Using orElseThrow() to retrieve the from and to nodes of an edge can cause a NoSuchElementException and crash the application if there is any inconsistency in the network model (e.g., if a node is deleted or missing). It is safer to use orElse(null) and skip the edge if either node is missing, which is also consistent with how NetworkRenderer handles edge rendering.

        for (TrackEdge edge : network.edges()) {
            TrackNode from = network.node(edge.fromNodeId()).orElse(null);
            TrackNode to = network.node(edge.toNodeId()).orElse(null);
            if (from == null || to == null) {
                continue;
            }
            Vec2 a = new Vec2(from.x(), from.y());
            Vec2 b = new Vec2(to.x(), to.y());
            double distance = Geometry.distanceToSegment(p, a, b);
            if (distance <= closestDistance) {
                closestDistance = distance;
                closestParam = Geometry.nearestParam(p, a, b);
                closestEdge = edge;
            }
        }

[gemini-code-assist]

An edge connecting a node to itself (a self-loop) is topologically invalid for a rail network. Consider adding a validation check in addEdge to prevent self-loops.

Suggested change

	public TrackEdge addEdge(String fromNodeId, String toNodeId) {
	if (!nodes.containsKey(fromNodeId) || !nodes.containsKey(toNodeId)) {
	throw new IllegalArgumentException(
	"Edge references unknown node: " + fromNodeId + " -> " + toNodeId);
	}
	public TrackEdge addEdge(String fromNodeId, String toNodeId) {
	if (java.util.Objects.equals(fromNodeId, toNodeId)) {
	throw new IllegalArgumentException("Cannot create self-loop edge on node: " + fromNodeId);
	}
	if (!nodes.containsKey(fromNodeId) || !nodes.containsKey(toNodeId)) {
	throw new IllegalArgumentException(
	"Edge references unknown node: " + fromNodeId + " -> " + toNodeId);
	}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bb50edf3d1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Avoid adding nodes on occupied clicks

When the NODE tool is active and the user clicks an existing node or within its hit radius, this unconditionally creates another node at the same spot even though AGENTS.md's editing model says NODE clicks add nodes in empty space. That leaves visually overlapping nodes; hit-testing then prefers the last closest node, so the original can become effectively unselectable and new edges may attach to an invisible duplicate. Guard with findNodeAt(x, y) before calling addNode.

Useful? React with 👍 / 👎.