Skip to content

Conversation

@chenjiahan
Copy link
Member

Enable all Rsbuild plugin tests.

Copilot AI review requested due to automatic review settings January 30, 2026 08:54
@chenjiahan chenjiahan merged commit 04eafb2 into main Jan 30, 2026
14 of 20 checks passed
@chenjiahan chenjiahan deleted the rsbuild_plugin_0130 branch January 30, 2026 08:54
@gemini-code-assist
Copy link

Summary of Changes

Hello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the testing infrastructure for the Rsbuild project. By uncommenting a substantial list of plugin entries in the test configuration file, it ensures that a much broader range of Rsbuild plugins are now actively included in the automated testing process. This change is crucial for maintaining the stability and reliability of the Rsbuild plugin ecosystem.

Highlights

  • Rsbuild Plugin Testing: A total of 25 previously commented-out Rsbuild plugins have been re-enabled in the test suite within tests/rsbuild/plugins.ts. This significantly expands the test coverage for various Rsbuild plugins, ensuring their proper functionality.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully enables all Rsbuild plugin tests by uncommenting the respective plugin entries in the plugins array within tests/rsbuild/plugins.ts. This change directly aligns with the stated goal of the pull request and appears to be a straightforward activation of previously disabled tests. No issues were found that require specific review comments.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables testing for 25 Rsbuild plugins that were previously commented out in the test suite. The change uncomments plugin names in the plugins array, which will cause the ecosystem CI to run tests against each of these plugin repositories.

Changes:

  • Uncommented 25 Rsbuild plugin entries in the test configuration array

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants