-
Notifications
You must be signed in to change notification settings - Fork 0
fix: enable Rsbuild plugin tests #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the testing infrastructure for the Rsbuild project. By uncommenting a substantial list of plugin entries in the test configuration file, it ensures that a much broader range of Rsbuild plugins are now actively included in the automated testing process. This change is crucial for maintaining the stability and reliability of the Rsbuild plugin ecosystem. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request successfully enables all Rsbuild plugin tests by uncommenting the respective plugin entries in the plugins array within tests/rsbuild/plugins.ts. This change directly aligns with the stated goal of the pull request and appears to be a straightforward activation of previously disabled tests. No issues were found that require specific review comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enables testing for 25 Rsbuild plugins that were previously commented out in the test suite. The change uncomments plugin names in the plugins array, which will cause the ecosystem CI to run tests against each of these plugin repositories.
Changes:
- Uncommented 25 Rsbuild plugin entries in the test configuration array
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Enable all Rsbuild plugin tests.