Skip to content

Fix: enabled -> disabled -> enabled button flow #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elnelson575 merged 1 commit into from
Feb 4, 2026
Merged

Fix: enabled -> disabled -> enabled button flow #1286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion inst/components/dist/components.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions inst/components/dist/components.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion inst/components/dist/components.min.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions inst/components/dist/components.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion srcts/src/components/toolbarInputButton.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ class BslibToolbarInputButtonBinding extends InputBinding {

async receiveMessage(el: HTMLElement, message: ToolbarInputButtonMessage) {
// Update disabled state
if (hasDefinedProperty(message, "disabled") && message.disabled) {
if (hasDefinedProperty(message, "disabled")) {
(el as HTMLButtonElement).disabled = message.disabled;
}

Expand Down
46 changes: 46 additions & 0 deletions tests/testthat/test-toolbar.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -976,3 +976,49 @@ test_that("update_toolbar_input_button() warns for blank label", {
"non-empty string label"
)
})

test_that("update_toolbar_input_button() can disable and reenable button", {
# Mock session that captures sendInputMessage calls
session <- list(
sendInputMessage = function(id, message) {
session$last_id <<- id
session$last_message <<- message
}
)

# Test disabling a button
update_toolbar_input_button(
"test_btn",
label = "Test Button",
disabled = TRUE,
session = session
)

expect_equal(session$last_id, "test_btn")
expect_equal(session$last_message$disabled, TRUE)

# Test re-enabling a button
update_toolbar_input_button(
"test_btn",
label = "Test Button",
disabled = FALSE,
session = session
)

expect_equal(session$last_id, "test_btn")
expect_equal(session$last_message$disabled, FALSE)

# Test updating multiple properties including disabled state
update_toolbar_input_button(
"test_btn",
label = "Updated",
icon = shiny::icon("check"),
disabled = TRUE,
session = session
)

expect_equal(session$last_id, "test_btn")
expect_equal(session$last_message$disabled, TRUE)
expect_true(!is.null(session$last_message$label))
expect_true(!is.null(session$last_message$icon))
})
Loading