Reconstruct migration record from contentId when no local record exists - #1358
Open
vrsarah wants to merge 3 commits into
Open
Reconstruct migration record from contentId when no local record exists#1358vrsarah wants to merge 3 commits into
vrsarah wants to merge 3 commits into
Conversation
…d exists migrateToConnectCloud() previously aborted when the app directory had no deployment record on disk, leaving no path for users who have lost their rsconnect/ directory (e.g. content deployed long ago on a machine they no longer have). Make the source deployment record optional: when none is found, build the Connect Cloud record from contentId alone -- the record name comes from appName, or is derived from the content title via generateAppName() -- and skip the source-removal step. The has-record path is unchanged.
…issing content, contentId validation)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1353. Closes https://github.com/rstudio/lucid-server/issues/5706
For users whose local record is gone, the merged version had no recovery path - this closes that gap without requiring the shinyapps source bundle or
appId. When no source record is found:contentIdalone (whichgetContent()already verifies exists).namecomes fromappName, or is derived from the content's title viagenerateAppName()whenappNameis omitted - Connect Cloud content has no server-side name to reuse, only a title.Testing
migrateToConnectCloud(appDir, contentId)from a working directory where there is no deployment record.contentId.deployApp(appDir)should send deployments to connect.posit.cloud.