Skip to content

fixed unit test workflow - #36

Merged
rsun19 merged 4 commits into
mainfrom
fix-ci
May 14, 2026
Merged

rsun19 merged 4 commits into
mainfrom
fix-ci

Conversation

@rsun19

@rsun19 rsun19 commented May 14, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Tests
    • Unit tests now run in CI on every change; deployments are gated on successful test runs. Test scripts updated so coverage commands tolerate absent tests.
  • API
    • Trip-stop responses now include a scheduled arrival field.
  • Reliability
    • Real-time and static feed handling improved for more robust data ingestion and alert/vehicle parsing.
  • Chores
    • Tooling updated (TypeScript/linters/configs) to modernize the build environment.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 14, 2026

Copy link
Copy Markdown

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR adds a new unit CI job to the GitHub Actions workflow. The job checks out code, configures Node 20, installs dependencies for both the root and frontend packages, and runs npm run test:unit. The deploy job is updated to depend on this new job, ensuring unit tests pass before deployment.

Changes

CI Unit Testing Integration

Layer / File(s) Summary
Unit test CI job definition
.github/workflows/ci.yml
New unit job runs on ubuntu-latest, sets up Node 20 with npm cache, installs root and frontend dependencies, and executes npm run test:unit. The deploy job is updated to wait for unit completion via needs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

A rabbit hops through workflows bright,
Where tests now run with all their might,
Before the deploy takes flight so high,
Unit checks ensure things fly right by! 🐰✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'fixed unit test workflow' is vague and overly broad. While the PR does include CI workflow changes (adding a unit test job), it encompasses far more extensive modifications including TypeScript configuration updates across multiple services, dependency version upgrades, ESLint setup, and refactoring of service implementations. Consider using a more descriptive title that reflects the broader scope, such as 'Update TypeScript config and add unit test CI workflow' or 'Migrate to node16 modules and add unit testing pipeline'.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-ci

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rsun19
rsun19 merged commit ac4eb18 into main May 14, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant