Skip to content

fixed deploy step in ci - #37

Merged
rsun19 merged 1 commit into
mainfrom
fix-deploy-ci
May 15, 2026
Merged

rsun19 merged 1 commit into
mainfrom
fix-deploy-ci

Conversation

@rsun19

@rsun19 rsun19 commented May 15, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Chores
    • Updated TypeScript configuration files across services to establish consistent source directory settings.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 15, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 03b7efa4-940d-4801-bc1b-91c3b16a83d4

📥 Commits

Reviewing files that changed from the base of the PR and between ac4eb18 and 369b181.

📒 Files selected for processing (6)
  • services/agencies/tsconfig.json
  • services/alerts/tsconfig.json
  • services/ingestion/tsconfig.json
  • services/routes/tsconfig.json
  • services/stops/tsconfig.json
  • services/vehicles/tsconfig.json

📝 Walkthrough

Walkthrough

Six service-level tsconfig.json files are updated to add rootDir: "./src" to compilerOptions. The change is uniform across all services: agencies, alerts, ingestion, routes, stops, and vehicles.

Changes

TypeScript rootDir Configuration

Layer / File(s) Summary
Add rootDir to all service tsconfig.json files
services/agencies/tsconfig.json, services/alerts/tsconfig.json, services/ingestion/tsconfig.json, services/routes/tsconfig.json, services/stops/tsconfig.json, services/vehicles/tsconfig.json
Each service's TypeScript configuration now explicitly sets compilerOptions.rootDir to ./src, establishing the source root directory for compilation output across the microservices.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • rsun19/transit-tracker#31: Main PR's updates to compilerOptions.rootDir in the existing per-service services/*/tsconfig.json files are a direct follow-on to PR #31's creation of those microservice-specific tsconfig.json setups.

Poem

🐰 Six configs, one simple fix,
rootDir points to source, oh what a mix!
From agencies bright to vehicles grand,
TypeScript knows where to expand—
Consistency blooms across the land! 🌱

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'fixed deploy step in ci' does not accurately describe the changeset, which adds rootDir configuration to six TypeScript tsconfig.json files. Update the title to reflect the actual changes, such as 'Add rootDir compiler option to service TypeScript configurations' or 'Configure rootDir in TypeScript compiler options for all services'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-deploy-ci

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rsun19
rsun19 merged commit 9c43133 into main May 15, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant