Merge develop into main by theMasudRana · Pull Request #39 · rtCamp/carousel-kit

theMasudRana · 2026-02-16T11:19:09Z

Description: Merge develop into main

[Docs]: Update README with requirements, browser support, and FAQs

- Updated block.json files to change names and categories from "core-carousel" to "carousel-kit". - Modified edit.tsx, save.tsx, and style.scss files to reflect new class names and attributes. - Adjusted editor-context.ts and editor.scss for context and styling changes. - Updated index.ts and view.ts to register and manage the new block structure. - Refactored tests to align with the new "carousel-kit" namespace and structure. - Ensured all references to "core-carousel" are replaced with "carousel-kit" across the codebase.

[Refactor]: Update plugin name from core carousel to carousel kit

Remove hardcoded loop: false in the editor viewport component to respect carousel settings.

Introduce conditional spacing using CSS gap for standard carousels and margins for looping carousels. This ensures consistent gaps when slides wrap around while avoiding extra trailing space in normal mode.

Update version in package.json and plugin header, and add v1.0.1 entries to CHANGELOG.md.

…o fix/playground

…o fix/carousel-loop-spacing

Copilot

Pull request overview

This pull request merges the develop branch into main, implementing a comprehensive rename of the plugin from "Core Carousel" to "Carousel Kit". The PR includes namespace changes, constant renames, CSS class updates, documentation updates, and bug fixes for carousel loop mode spacing.

Changes:

Renamed plugin from "Core Carousel" to "Carousel Kit" across all files (PHP namespaces, constants, CSS classes, block names, text domains)
Fixed carousel loop mode spacing issues by adding data-loop attribute and CSS gap handling
Updated dependencies (@testing-library/jest-dom from ^6.6.3 to 6.9.1, axios to 1.13.5)
Version bump from 1.0.0 to 1.0.1

Reviewed changes

Copilot reviewed 56 out of 61 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
carousel-kit.php	New main plugin file with Carousel_Kit namespace and CAROUSEL_KIT_* constants
core-carousel.php	Deleted old main plugin file
src/blocks/carousel/styles/_core.scss	Updated CSS class names and added loop mode gap handling (incomplete - has old class names)
src/blocks/carousel/viewport/edit.tsx	Fixed loop mode to respect options instead of hardcoding false
src/blocks/carousel/save.tsx	Added data-loop attribute for proper loop mode styling
src/blocks/carousel/edit.tsx	Added data-loop attribute in editor view
package.json	Version bump to 1.0.1 (name not updated - critical issue)
package-lock.json	Name updated but version mismatch (critical issue)
composer.json	Namespace updated to Carousel_Kit
inc/Plugin.php	Namespace and constant updates
inc/Traits/Singleton.php	Namespace and hook name updates
tests/*	Updated namespaces, constants, and test expectations
docs/*	Documentation updated with new naming
.github/workflows/release.yml	Has YAML indentation errors and old filename reference (critical issues)
blueprint.json	Has old repository and filename references (critical issue)
examples/patterns/*	Pattern files updated with new block names
phpunit.xml.dist, phpstan.neon.dist, phpcs.xml.dist	Configuration files updated with new filename

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-16T11:23:57Z

src/blocks/carousel/styles/_core.scss

+:where(.core-carousel[data-loop="true"]) .embla__container,
+:where(.core-carousel[data-loop="true"]) .embla .wp-block-post-template {
+	gap: 0;
+}
+
+:where(.core-carousel[data-loop="true"]) .embla__slide,
+:where(.core-carousel[data-loop="true"]) .embla .wp-block-post-template li {
+	margin-inline-end: var(--core-carousel-gap, 0);
+}
+
 /* Vertical Axis adjustments */
-:where(.core-carousel[data-axis="y"]) {
+:where(.carousel-kit[data-axis="y"]) {
 	display: flex;
 	flex-direction: column;
 }

-:where(.core-carousel[data-axis="y"]) .embla {
-	height: var(--core-carousel-height);
+:where(.carousel-kit[data-axis="y"]) .embla {
+	height: var(--carousel-kit-height);
 }

-:where(.core-carousel[data-axis="y"]) .embla__container {
+:where(.carousel-kit[data-axis="y"]) .embla__container {
 	flex-direction: column;
 	height: 100%;
 	min-height: 100%;
 }

-:where(.core-carousel[data-axis="y"]) .embla__slide,
-:where(.core-carousel[data-axis="y"]) .embla .wp-block-post-template li {
-	flex: 0 0 var(--core-carousel-slide-width, 100%);
+:where(.carousel-kit[data-axis="y"]) .embla__slide,
+:where(.carousel-kit[data-axis="y"]) .embla .wp-block-post-template li {
+	flex: 0 0 var(--carousel-kit-slide-width, 100%);
 	width: 100%;
 	max-width: 100%;
 	margin-inline-end: 0;
 }
+
+/* Vertical + Loop specific */
+:where(.core-carousel[data-axis="y"][data-loop="true"]) .embla__slide,
+:where(.core-carousel[data-axis="y"][data-loop="true"]) .embla .wp-block-post-template li {
+	margin-block-end: var(--core-carousel-gap, 0);
+}


The CSS selectors for loop mode still use the old class name core-carousel instead of the new carousel-kit. These selectors need to be updated to maintain consistency with the plugin rename. This affects:

.core-carousel[data-loop="true"] selectors (lines 51-52, 56-57)

CSS variable --core-carousel-gap (lines 58, 88)

The selectors should use .carousel-kit and the variable should be --carousel-kit-gap to match the rest of the stylesheet.

Copilot · 2026-02-16T11:23:57Z

package.json

@@ -1,6 +1,6 @@
 {
  "name": "core-carousel",


The package name in package.json is still "core-carousel" but should be "carousel-kit" to match the overall plugin rename. This inconsistency could cause confusion and issues with package management tools. Note that package-lock.json already has the correct name "carousel-kit", creating a mismatch between the two files.

Suggested change

"name": "core-carousel",

"name": "carousel-kit",

Copilot · 2026-02-16T11:23:58Z

.github/workflows/release.yml

+            - name: Create Release and Upload Asset
+
+              uses: softprops/action-gh-release@v1
+
+              with:
+
+                tag_name: v${{ steps.get_version.outputs.VERSION }}
+
+                name: v${{ steps.get_version.outputs.VERSION }}
+
+                generate_release_notes: true
+
+                files: core-carousel.zip
+
+              env:
+
+                GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+


The YAML indentation is incorrect starting from line 37. The step "Create Release and Upload Asset" and all its child properties have inconsistent extra indentation. In YAML, list items should be indented by 2 spaces from their parent, but lines 37-53 use excessive indentation (12 spaces for the step name instead of 6). This will cause the GitHub Actions workflow to fail with a syntax error.

Suggested change

- name: Create Release and Upload Asset

uses: softprops/action-gh-release@v1

with:

tag_name: v${{ steps.get_version.outputs.VERSION }}

name: v${{ steps.get_version.outputs.VERSION }}

generate_release_notes: true

files: core-carousel.zip

env:

GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Create Release and Upload Asset

uses: softprops/action-gh-release@v1

with:

tag_name: v${{ steps.get_version.outputs.VERSION }}

name: v${{ steps.get_version.outputs.VERSION }}

generate_release_notes: true

files: core-carousel.zip

env:

GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Copilot · 2026-02-16T11:23:58Z

.github/workflows/release.yml

+
+                generate_release_notes: true
+
+                files: core-carousel.zip


The workflow still references the old filename "core-carousel.zip" instead of "carousel-kit.zip". Based on the Makefile changes, the build process now generates "carousel-kit.zip", so this files reference will fail during the release step. The filename should be updated to "carousel-kit.zip" to match the new plugin name.

Suggested change

files: core-carousel.zip

files: carousel-kit.zip

Copilot · 2026-02-16T11:23:58Z

blueprint.json

            "pluginData": {
                "resource": "url",
-                "url": "https://cdn.statically.io/gh/rtCamp/core-carousel@dist/core-carousel.zip"
+                "url": "https://github.com/rtCamp/core-carousel/releases/latest/download/core-carousel.zip"


The blueprint.json file contains outdated references to the old plugin repository and file names:

Line 13: URL still points to "rtCamp/core-carousel" repository instead of "rtCamp/carousel-kit"

Line 13: ZIP filename is "core-carousel.zip" instead of "carousel-kit.zip"

These URLs need to be updated to point to the renamed repository and the correct ZIP filename, otherwise the WordPress Playground demo will fail to install the plugin.

Suggested change

"url": "https://github.com/rtCamp/core-carousel/releases/latest/download/core-carousel.zip"

"url": "https://github.com/rtCamp/carousel-kit/releases/latest/download/carousel-kit.zip"

Fix: replace core-carousel with carousel-kit

theMasudRana and others added 18 commits February 11, 2026 18:19

docs: Update README with requirements, browser support, and FAQs

9abebab

docs: Update contributor link for Masud Rana and add spacing in README

1208152

feat: remove dist branch creation on release

424c29c

fix: change plugin url to github releases

38fe671

chore: update packages

01a8002

feat: add tests tsconfig

6ab9931

fix: doc params

f2abd09

Merge pull request #34 from rtCamp/feat/readme-update

59578bc

[Docs]: Update README with requirements, browser support, and FAQs

Merge pull request #36 from rtCamp/feat/carousel-kit

4161f9d

[Refactor]: Update plugin name from core carousel to carousel kit

fix(carousel): allow infinite loop in editor viewport

0f604a1

Remove hardcoded loop: false in the editor viewport component to respect carousel settings.

fix(carousel): resolve spacing issues in loop mode

e8c02d8

Introduce conditional spacing using CSS gap for standard carousels and margins for looping carousels. This ensures consistent gaps when slides wrap around while avoiding extra trailing space in normal mode.

chore: bump version to 1.0.1

f868bba

Update version in package.json and plugin header, and add v1.0.1 entries to CHANGELOG.md.

feat: improve demo

d15e11a

Merge branch 'develop' of https://github.com/rtCamp/core-carousel int…

d2c7ab9

…o fix/playground

Merge pull request #35 from rtCamp/fix/playground

e0c8352

Merge branch 'develop' of https://github.com/rtCamp/core-carousel int…

b17f643

…o fix/carousel-loop-spacing

Merge pull request #38 from rtCamp/fix/carousel-loop-spacing

6d76703

Copilot AI review requested due to automatic review settings February 16, 2026 11:19

Copilot started reviewing on behalf of theMasudRana February 16, 2026 11:19 View session

danish17 previously approved these changes Feb 16, 2026

View reviewed changes

Copilot AI reviewed Feb 16, 2026

View reviewed changes

danish17 and others added 2 commits February 16, 2026 14:37

fix: replace core-carousel with carousel-kit

903736c

Merge pull request #40 from rtCamp/fix/replace-old-occurences

e60fa05

Fix: replace core-carousel with carousel-kit

danish17 dismissed their stale review via e60fa05 February 16, 2026 15:50

danish17 requested a review from imrraaj February 16, 2026 15:53

imrraaj approved these changes Feb 16, 2026

View reviewed changes

danish17 merged commit 90462df into main Feb 16, 2026
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Merge develop into main#39

Merge develop into main#39
danish17 merged 20 commits intomainfrom
develop

theMasudRana commented Feb 16, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 16, 2026

Uh oh!

Copilot AI Feb 16, 2026

Uh oh!

Copilot AI Feb 16, 2026

Uh oh!

Copilot AI Feb 16, 2026

Uh oh!

Copilot AI Feb 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	"url": "https://github.com/rtCamp/core-carousel/releases/latest/download/core-carousel.zip"
	"url": "https://github.com/rtCamp/carousel-kit/releases/latest/download/carousel-kit.zip"

Comments

Conversation

theMasudRana commented Feb 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants