optionals with new_union default to NULL #2
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,10 @@ | ||
| ^__dev$ | ||
| ^\.github$ | ||
| ^.*\.code-workspace$ | ||
| ^revdep$ | ||
| ^specs$ | ||
| ^AGENTS\.md$ | ||
| ^CLAUDE\.md$ | ||
| ^Makefile$ | ||
| ^SKILL\.md$ | ||
| ^cran-comments\.md$ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| # R-hub's generic GitHub Actions workflow file. It's canonical location is at | ||
| # https://github.com/r-hub/actions/blob/v1/workflows/rhub.yaml | ||
| # You can update this file to a newer version using the rhub2 package: | ||
| # | ||
| # rhub::rhub_setup() | ||
| # | ||
| # It is unlikely that you need to modify this file manually. | ||
|
|
||
| name: R-hub | ||
| run-name: "${{ github.event.inputs.id }}: ${{ github.event.inputs.name || format('Manually run by {0}', github.triggering_actor) }}" | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| config: | ||
| description: 'A comma separated list of R-hub platforms to use.' | ||
| type: string | ||
| default: 'linux,windows,macos' | ||
| name: | ||
| description: 'Run name. You can leave this empty now.' | ||
| type: string | ||
| id: | ||
| description: 'Unique ID. You can leave this empty now.' | ||
| type: string | ||
|
|
||
| jobs: | ||
|
|
||
| setup: | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| containers: ${{ steps.rhub-setup.outputs.containers }} | ||
| platforms: ${{ steps.rhub-setup.outputs.platforms }} | ||
|
|
||
| steps: | ||
| # NO NEED TO CHECKOUT HERE | ||
| - uses: r-hub/actions/setup@v1 | ||
| with: | ||
| config: ${{ github.event.inputs.config }} | ||
| id: rhub-setup | ||
|
|
||
| linux-containers: | ||
| needs: setup | ||
| if: ${{ needs.setup.outputs.containers != '[]' }} | ||
| runs-on: ubuntu-latest | ||
| name: ${{ matrix.config.label }} | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| config: ${{ fromJson(needs.setup.outputs.containers) }} | ||
| container: | ||
| image: ${{ matrix.config.container }} | ||
|
|
||
| steps: | ||
| - uses: r-hub/actions/checkout@v1 | ||
| - uses: r-hub/actions/platform-info@v1 | ||
| with: | ||
| token: ${{ secrets.RHUB_TOKEN }} | ||
| job-config: ${{ matrix.config.job-config }} | ||
| - uses: r-hub/actions/setup-deps@v1 | ||
| with: | ||
| token: ${{ secrets.RHUB_TOKEN }} | ||
| job-config: ${{ matrix.config.job-config }} | ||
| - uses: r-hub/actions/run-check@v1 | ||
| with: | ||
| token: ${{ secrets.RHUB_TOKEN }} | ||
| job-config: ${{ matrix.config.job-config }} | ||
|
|
||
| other-platforms: | ||
| needs: setup | ||
| if: ${{ needs.setup.outputs.platforms != '[]' }} | ||
| runs-on: ${{ matrix.config.os }} | ||
| name: ${{ matrix.config.label }} | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| config: ${{ fromJson(needs.setup.outputs.platforms) }} | ||
|
|
||
| steps: | ||
| - uses: r-hub/actions/checkout@v1 | ||
| - uses: r-hub/actions/setup-r@v1 | ||
| with: | ||
| job-config: ${{ matrix.config.job-config }} | ||
| token: ${{ secrets.RHUB_TOKEN }} | ||
| - uses: r-hub/actions/platform-info@v1 | ||
| with: | ||
| token: ${{ secrets.RHUB_TOKEN }} | ||
| job-config: ${{ matrix.config.job-config }} | ||
| - uses: r-hub/actions/setup-deps@v1 | ||
| with: | ||
| job-config: ${{ matrix.config.job-config }} | ||
| token: ${{ secrets.RHUB_TOKEN }} | ||
| - uses: r-hub/actions/run-check@v1 | ||
| with: | ||
| job-config: ${{ matrix.config.job-config }} | ||
| token: ${{ secrets.RHUB_TOKEN }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests don’t currently assert the new intended behavior that these optional_* properties can be omitted and will default to NULL (now relying on
new_union(NULL, ...)rather than an explicitdefault = NULL). Please add a test that constructs a class with one of these properties and verifies the field isNULLwhen not provided (and that construction succeeds).