Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces two new S7 properties, nonneg_integer_scalar and optional_nonneg_integer_scalar, along with their corresponding documentation and exports. Additionally, the roxygen2 configuration has been updated to version 8.0.0, resulting in the regeneration of several documentation files. Feedback from the review highlights that the new integer scalar properties lack unit tests, particularly for verifying boundary cases like 0L and the rejection of negative values.
There was a problem hiding this comment.
Pull request overview
This PR extends the package’s library of S7 properties by adding a non-negative integer scalar property (and optional variant), and refreshes generated documentation/metadata accordingly.
Changes:
- Add
nonneg_integer_scalarandoptional_nonneg_integer_scalarS7 properties with validators enforcing>= 0L. - Export the new properties in
NAMESPACEand add generated Rd docs for them. - Regenerate/update various Rd files and roxygen-related metadata/config (plus ignore
cran-comments.mdin builds).
Reviewed changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| R/00_S7_properties.R | Adds the new non-negative integer scalar S7 properties and updates the TOC. |
| NAMESPACE | Exports nonneg_integer_scalar and optional_nonneg_integer_scalar. |
| man/nonneg_integer_scalar.Rd | New generated documentation for nonneg_integer_scalar. |
| man/optional_nonneg_integer_scalar.Rd | New generated documentation for optional_nonneg_integer_scalar. |
| man/*.Rd | Regenerated docs (notably removing prior \docType{data} / \format{} / \keyword{datasets} blocks for several objects). |
| man/rtemis.core-package.Rd | Updates package-level author block content. |
| DESCRIPTION | Updates roxygen-related fields/configuration. |
| .Rbuildignore | Ignores cran-comments.md during package build. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.