Skip to content

Dev#3

Merged
egenn merged 5 commits into
mainfrom
dev
May 7, 2026
Merged

Dev#3
egenn merged 5 commits into
mainfrom
dev

Conversation

@egenn
Copy link
Copy Markdown
Member

@egenn egenn commented May 7, 2026

No description provided.

Copilot AI review requested due to automatic review settings May 7, 2026 10:20
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces two new S7 properties, nonneg_integer_scalar and optional_nonneg_integer_scalar, along with their corresponding documentation and exports. Additionally, the roxygen2 configuration has been updated to version 8.0.0, resulting in the regeneration of several documentation files. Feedback from the review highlights that the new integer scalar properties lack unit tests, particularly for verifying boundary cases like 0L and the rejection of negative values.

Comment thread R/00_S7_properties.R
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the package’s library of S7 properties by adding a non-negative integer scalar property (and optional variant), and refreshes generated documentation/metadata accordingly.

Changes:

  • Add nonneg_integer_scalar and optional_nonneg_integer_scalar S7 properties with validators enforcing >= 0L.
  • Export the new properties in NAMESPACE and add generated Rd docs for them.
  • Regenerate/update various Rd files and roxygen-related metadata/config (plus ignore cran-comments.md in builds).

Reviewed changes

Copilot reviewed 34 out of 34 changed files in this pull request and generated no comments.

Show a summary per file
File Description
R/00_S7_properties.R Adds the new non-negative integer scalar S7 properties and updates the TOC.
NAMESPACE Exports nonneg_integer_scalar and optional_nonneg_integer_scalar.
man/nonneg_integer_scalar.Rd New generated documentation for nonneg_integer_scalar.
man/optional_nonneg_integer_scalar.Rd New generated documentation for optional_nonneg_integer_scalar.
man/*.Rd Regenerated docs (notably removing prior \docType{data} / \format{} / \keyword{datasets} blocks for several objects).
man/rtemis.core-package.Rd Updates package-level author block content.
DESCRIPTION Updates roxygen-related fields/configuration.
.Rbuildignore Ignores cran-comments.md during package build.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@egenn egenn merged commit 00d5f7a into main May 7, 2026
6 checks passed
@egenn egenn deleted the dev branch May 7, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants