Skip to content

chore: enable the recommended ex_slop checks - #85

Merged
rubas merged 2 commits into
mainfrom
chore/ex-slop-recommended-checks
Sep 23, 2026
Merged

rubas merged 2 commits into
mainfrom
chore/ex-slop-recommended-checks

Conversation

@rubas

@rubas rubas commented Sep 23, 2026

Copy link
Copy Markdown
Owner

Changes

  • Version: mix.lock already has ex_slop 0.4.5, the latest release. No bump is necessary. The mix.exs requirement stays ~> 0.4.
  • Config: .credo.exs no longer lists the 30 ExSlop checks one by one. The enabled list now ends with Enum.map(ExSlop.recommended_checks(), &{&1, []}), as the ex_slop README recommends. A new ex_slop version now adds its new recommended checks automatically. mix credo info --verbose shows 31 active ExSlop checks.
  • New check: ExSlop.Check.Refactor.LengthComparison found 7 issues in test/integration_test.exs. The fixes:
    • Concat CFR join: length(pts) >= 36 and length(pts) <= 44 is now Enum.count_until(pts, 45) in 36..44.
    • VFR crop: length(src_pts) == 20 and length(out_pts) == 20 is now length(out_pts) == length(src_pts). The List.last(src_pts) check at 1.85 s still pins the source to all 20 frames.
    • Duplicate pts: length(src_pts) == 20 is now a check that every pts occurs twice, which is the precondition that the test comment describes.
    • Raw H.264 and FFV1 10 fps: length(pts) == 20 is now Enum.count_until(pts, 21) == 20.

Checks

  • task lint: credo strict with no issues, clippy clean.
  • task test: 43 passed.
  • mix test --include integration: 104 passed.

@rubas
rubas merged commit 4fc5cdd into main Sep 23, 2026
1 check passed
@rubas
rubas deleted the chore/ex-slop-recommended-checks branch September 23, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant