Repository navigation
chore: enable the recommended ex_slop checks - #85
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
mix.lockalready hasex_slop0.4.5, the latest release. No bump is necessary. Themix.exsrequirement stays~> 0.4..credo.exsno longer lists the 30 ExSlop checks one by one. Theenabledlist now ends withEnum.map(ExSlop.recommended_checks(), &{&1, []}), as the ex_slop README recommends. A new ex_slop version now adds its new recommended checks automatically.mix credo info --verboseshows 31 active ExSlop checks.ExSlop.Check.Refactor.LengthComparisonfound 7 issues intest/integration_test.exs. The fixes:length(pts) >= 36 and length(pts) <= 44is nowEnum.count_until(pts, 45) in 36..44.length(src_pts) == 20 and length(out_pts) == 20is nowlength(out_pts) == length(src_pts). TheList.last(src_pts)check at 1.85 s still pins the source to all 20 frames.length(src_pts) == 20is now a check that every pts occurs twice, which is the precondition that the test comment describes.length(pts) == 20is nowEnum.count_until(pts, 21) == 20.Checks
task lint: credo strict with no issues, clippy clean.task test: 43 passed.mix test --include integration: 104 passed.