Repository navigation
Update the Rust dependencies to their latest compatible versions - #94
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before.
cargo updateinnative/exmpeg_nativefinds newer compatible versions of 9 crates:Problem. The lock file of the NIF is behind the compatible releases on crates.io.
After. The lock file has the newest compatible versions. Only
Cargo.lockchanges.bon,bon-macroseitherinventorylibcsyn(3.x)thiserror,thiserror-implunicode-identrustlerrsmpeg(git,rubas/rsmpeg)5055c6d5055c6d(not changed)rustlerstays at 0.38. Version 0.39 breakscargo teston Linux.Details
Why
rustler0.39 is not in this PR. In 0.38,rustler::syscalled theenif_*functions through a table that it filled at load time. In 0.39 (#749, "Generaterustler::sysdirectly from the upstream header"), Linux links theenif_*symbols directly (otp_headers/*/api.8.direct.rs). The test binary of the crate has no BEAM to supply these symbols, so the link fails:The NIF itself builds with 0.39: clippy passes and
task test:integrationpasses (107 tests). Onlytask test:rustfails. A linker flag such as-Wl,--unresolved-symbols=ignore-allmakes the 19 Rust tests link and pass, but that is a workaround for an upstream change. The Elixir packagerustleron Hex is still 0.38.0, somix.exsandmix.lockdo not change.Checks (local, Rust 1.98.1, FFmpeg 9).
task check: format,mix compile --warnings-as-errorswith the NIF built from source, credo, clippy,mix test(43 passed),cargo test(19 passed), zizmor.task test:integration: 107 passed.