Repository navigation
deps: cargo update and scraper 0.29 - #59
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
task outdatedonmain:cargo updatealso found 32 newer compatible versions inCargo.lock.Problem
The lock file was behind, and
scraperwas one major version behind (0.28 was not released on GitHub, so 0.29 is the next one).After
task outdatedshows no update. The search parser still finds the results on a live Kagi page.scraper(major)tokioserde_jsonselectors(viascraper)cssparser(viascraper)html5ever(viascraper)Live run with the new parser:
Details
Changes. Two commits: first
cargo update, thenscraper0.27 to 0.29 inCargo.toml. The version ofkagistays at 0.7.0, so this PR does not start a release.scraper 0.29. The release notes list docs, a new
selectorsversion, and a newcssparserversion with changed error handling insidescraper. Our code insrc/parse.rsuses onlyHtml::parse_document,Selector::parse, andselect. Their API did not change, and the source of 0.29 marks nothing as deprecated. No code change was necessary.Checks (local).
cargo fmt --check,npx dprint check: pass.cargo clippy --all-targets -- -D warnings: pass.zizmor --offline --persona=pedantic .github/workflows: no findings.cargo test: all tests pass, with the 19 parser tests on the HTML fixtures.cargo test --test live -- --ignored(real Kagi service): 4 of 4 pass.cargo check --release,cargo machete,cargo deny check advisories bans sources: pass.kagi-searchwith 0.27 (main) and 0.29 (this branch) gives the same results.