fix: clamp Write-Progress PercentComplete to 100 max#121
Open
mtellin wants to merge 1 commit into
Open
Conversation
mtellin
requested review from
bhaskard,
srikar-rubrik-dev and
visharma28
as code owners
Wrap all PercentComplete calculations with [math]::Min(..., 100) to prevent values exceeding 100 when counter overshoots (e.g. last item rounding or off-by-one). Applies to all 19 Write-Progress calls across EC2, S3, RDS, EFS, EKS, FSx, KMS, Backup, and profile/account loops. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mtellin
force-pushed
the
fix/clamp-write-progress-percent
branch
from
791e50d to
0493eef
Compare
stevenctong
approved these changes
Jun 18, 2026
stevenctong
left a comment
stevenctong
left a comment
Contributor
There was a problem hiding this comment.
Code review: all 19 Write-Progress PercentComplete calls are correctly clamped with [math]::Min(..., 100). Mechanical change, no logic modifications, no regressions. Existing KMS division-by-zero guard preserved. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Write-Progress -PercentCompletecalculations in[math]::Min(..., 100)to prevent values exceeding the valid 0–100 rangeCloses #79
Closes #81
Test plan
Get-AWSSizingInfo.ps1against an account with backup plans that have multiple selections per planPercentCompletevalidation errors🤖 Generated with Claude Code