fix: guard against null backup costs in GovCloud#122
Open
mtellin wants to merge 1 commit into
Open
Conversation
Cost Explorer endpoints don't exist in all GovCloud regions, causing
null AWSBackupNetUnblendedCost values that crash on TrimStart('$').
Adds a null filter before decimal conversion and initializes the
total to 0 so the summary line renders cleanly when no cost data
is available.
Closes #80
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mtellin
requested review from
bhaskard,
srikar-rubrik-dev and
visharma28
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$backupTotalNetUnblendedCostto 0 so the summary line doesn't show blank when Cost Explorer is unavailableWhere-Object { $null -ne $_ }filter beforeTrimStart('$')to prevent null reference crash$backupCostsList.Count -eq 0check alongside the existing null check for robustnessThe Cost Explorer endpoint (
ce.<region>.amazonaws.com) doesn't exist in all GovCloud regions, causing the script to crash with "You cannot call a method on a null-valued expression" when it tries to parse cost strings.Closes #80
Test plan
Get-AWSSizingInfo.ps1 -Partition GovCloudagainst an account with access tous-gov-west-1andus-gov-east-1$0instead of crashing or showing blank🤖 Generated with Claude Code