Skip to content

Add ruby 4.0 in GH action #2650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dblock merged 1 commit into from
Dec 27, 2025
Merged

Add ruby 4.0 in GH action #2650

dblock merged 1 commit into from
Dec 27, 2025

Conversation

@ericproulx
Copy link
Contributor

@ericproulx ericproulx commented Dec 27, 2025 •
edited
Loading

This PR adds ruby 4.0 in GH action.

It also includes a couple of fixes/changes

  • Some gemfiles were not actually installing the intended version. It has been fixed
  • RSpec exclude-pattern has been updated to excludes specific integrations tests only. Now, Rails integrations tests are running with all ruby versions when its a Rails gemfile. hashie, grape-entity, dry-validation, multi-json and multi-xml are running with ruby 4.0 only.
  • Dockerfile is not setup with slim version instead of alpine
  • Some tests have been updated to reflect Set.new in JSON. The latter seems to have changed with Ruby 4.0. Using to_json and JSON.parse is version agnostic compared to a literal string.
  • rack_3_0 integrations tests have been removed. It's been released for a while now and we already have rack_3_* gemfiles

@ericproulx ericproulx marked this pull request as draft December 27, 2025 11:12
@ericproulx ericproulx force-pushed the add_ruby_4_0_cli branch 8 times, most recently from 422990d to 115dd4a Compare December 27, 2025 12:01
@ericproulx ericproulx requested a review from dblock December 27, 2025 12:05
@ericproulx
- Add ruby 4.0 in GH action
9798cdb 
- Fix gemfile versioning for rails
- Update Dockerfile to use slim
- Update specs
- Remove rack_3 integration tests
@ericproulx ericproulx marked this pull request as ready for review December 27, 2025 12:12
@dblock dblock merged commit 13ed8d3 into master Dec 27, 2025
100 of 101 checks passed
@dblock dblock deleted the add_ruby_4_0_cli branch December 27, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dblock dblock dblock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ericproulx @dblock