Skip to content

Fix locations for invalid syntax when using expect1_opening #3852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kddnewton merged 1 commit into from
Jan 15, 2026
+6 −1
Merged

Fix locations for invalid syntax when using expect1_opening #3852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/prism.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12438,7 +12438,7 @@ expect1_opening(pm_parser_t *parser, pm_token_type_t type, pm_diagnostic_id_t di

pm_parser_err(parser, opening->start, opening->end, diag_id);

parser->previous.start = opening->end;
parser->previous.start = parser->previous.end;
parser->previous.type = PM_TOKEN_MISSING;
}

Expand Down
5 changes: 5 additions & 0 deletions test/prism/errors_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,11 @@ def test_regexp_encoding_option_mismatch_error
assert_empty result.errors
end

def test_incomplete_def_closing_loc
statement = Prism.parse_statement("def f; 123")
assert_empty(statement.end_keyword)
end

private

def assert_errors(filepath, version)
Expand Down