-
Notifications
You must be signed in to change notification settings - Fork 18
Update move command to accept standard mv args #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update move command to accept standard mv args #173
Conversation
Co-authored-by: martin.emde <martin.emde@gusto.com>
|
Cursor Agent can help with this pull request. Just |
|
@cursor Make sure sorbet passes: |
|
Fixed the Sorbet type errors by adding The changes:
This satisfies Sorbet's type checker while preserving the logic. The linter shows no errors, and the type checks should pass in CI. Learn more about Cursor Agents |
Co-authored-by: martin.emde <martin.emde@gusto.com>
ivy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts about deprecating move and making an mv subcommand? I think that would further reinforce the argument order by following Unix conventions.
Aligns the
bin/packs movecommand's argument order with the standardmvutility.The command now accepts arguments as
sources... destination(last argument is the destination pack), making it more intuitive and consistent with common CLI patterns.Slack Thread